-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover] Add Copy to clipboard
ability for column name of Document Explorer
#123892
Conversation
@elasticmachine merge upstream |
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
Copy to clipboard
ability for column name of Document Explorer
@elasticmachine merge upstream |
@elasticmachine merge upstream |
expected head sha didn’t match current head ref. |
src/plugins/discover/public/components/discover_grid/copy_column_name_button.tsx
Outdated
Show resolved
Hide resolved
@elasticmachine merge upstream |
…mn_name_button.tsx Co-authored-by: Matthias Wilhelm <ankertal@gmail.com>
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested in cloud with Safari, Firefox, Chrome, works as expected 👍 could you add a unit test for copy_column_name_button.tsx
, testing the triggering the function works? many thx!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unit test LGTM 👍 thx, didn't test again. Thx for this useful addon!
Can be merged once CI is green |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @dmitriynj |
…t Explorer (elastic#123892) * [Discover] copy column name to clipboard * [Discover] add ability to use it for http * [Discover] remove redundant span * [Discover] update unit tests * Update src/plugins/discover/public/components/discover_grid/copy_column_name_button.tsx Co-authored-by: Matthias Wilhelm <ankertal@gmail.com> * [Discover] import copyToClipboard util function from elastic ui * [Discover] add unit tests Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Matthias Wilhelm <ankertal@gmail.com>
When I used this feature I expected this would copy the values of the column and the column name vs. just the column name. |
So maybe we should describe it in a better way. And provide more functionality. |
We could drop "to clipboard" |
Love that idea, would be a simple change , and a little very helpful feature |
Summary
Closes #103657
This PR adds
Copy to clipboard
column action.Checklist
Delete any items that are not applicable to this PR.